Script Update Help

[SteveGiralt]

Hello,

I have a script that I have used for some time now - I basically copied the killcounter script from the TT++ website and adapted it to the mud I'm playing. For some reason it stopped working, though I haven't changed the code in a few years. I've messed around a little trying to figure out where it goes wrong but I'm still having troubles.

The gains list seems to be populating correctly, so I think it's my foreach loop. Any help would be appreciated!

#nop #list gains clear
#gag #solo#: Experience shared! -> By order of band leader!


#nop {Your share of the pool       : %1} {#math {lastkill} {%1 - $totalxp};#var totalxp %1}

#alias {loot} {#action {You killed %%1.} {#var victim %%1;gac;t;#var combat 0;share};#showme {Corpse looting ON.}}
#alias {noloot} {#action {You killed %%1.} {#var victim %%1;#var combat 0;share};#showme {Corpse looting OFF}}


#action {You have gained %1 experience points!} {#var lastkill %1;
        #math {gains[$victim][exp]} {$gains[$victim][exp] + $lastkill};
        #math {gains[$victim][cnt]} {$gains[$victim][cnt] + 1}
                }

#alias {rip}
{
        #showme {      Average Xp       Total Xp     #   Death List       };
        #showme {----------------------------------------------------------};

        #unvar {gains[final]};

        #foreach {$gains[]} {victim}
        {
                #echo {  %+14G %+14G %+5G   %s}
                        {$gains[$victim][exp] / $gains[$victim][cnt]}
                        {$gains[$victim][exp]}
                        {$gains[$victim][cnt]}
                        {$victim};

                #math gains[final][exp] $gains[final][exp] + $gains[$victim][exp];
                #math gains[final][cnt] $gains[final][cnt] + $gains[$victim][cnt]
        };
        #showme {----------------------------------------------------------};

        #math tmp {$gains[final][exp] / $gains[final][cnt]};

        #echo {  %+14G %+14G %+5G}
                {$tmp}
                {$gains[final][exp]}
                {$gains[final][cnt]}
}

It returns the following:

      Average Xp       Total Xp     #   Death List
----------------------------------------------------------
               0              0     0
               0              0     0
               0              0     0
               0              0     0
               0              0     0
               0              0     0
               0              0     0
----------------------------------------------------------
               0              0     0

[scandum]

#foreach {$gains[]} {victim}

Looks like that needs to be changed to:

#foreach {*gains[]} {victim}