Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

martian: run unit tests againts http2 server #869

Open
mmatczuk opened this issue Jul 26, 2024 · 0 comments
Open

martian: run unit tests againts http2 server #869

mmatczuk opened this issue Jul 26, 2024 · 0 comments
Milestone
v1.x

Comments

@mmatczuk
Copy link
Contributor

Previously we added tests running over TLS and against HTTP handler implementation.
Is's important to also run the tests against add HTTP2 server.

This is bit complicated as Go does not support http2 proxy servers out of the box,
and adding it would require tests fork or refactoring as we cannot send plain text.
Maybe we could make use of a translation layer or come with another trick to minimize the amount of changes.
@mmatczuk mmatczuk added this to the v1.4 milestone Jul 26, 2024
mmatczuk added a commit that referenced this issue Jul 26, 2024
@mmatczuk
martian(h2): fix half-close propagation downstream
fb8f70e 
Use http2.Response.Close() to send RST_STREAM frame.
Reimplement writeFlusher as h2Writer.

This is to be tested in Sauce Connect due to lack of testing infrastructure for http2 at the moment.
I added #869 to fix that.
mmatczuk added a commit that referenced this issue Jul 26, 2024
@mmatczuk
martian(h2): fix half-close propagation downstream
7afb0f9 
Use http2.Response.Close() to send RST_STREAM frame.
Reimplement writeFlusher as h2Writer.

This is to be tested in Sauce Connect due to lack of testing infrastructure for http2 at the moment.
I added #869 to fix that.
mmatczuk added a commit that referenced this issue Jul 26, 2024
@mmatczuk
martian(h2): fix half-close propagation downstream
804b2f5 
Use http2.Response.Close() to send RST_STREAM frame.
Reimplement writeFlusher as h2Writer.

This is to be tested in Sauce Connect due to lack of testing infrastructure for http2 at the moment.
I added #869 to fix that.
mmatczuk added a commit that referenced this issue Jul 29, 2024
@mmatczuk
martian(h2): fix half-close propagation downstream
32cac8f 
Use http2.Response.Close() to send RST_STREAM frame.
Reimplement writeFlusher as h2Writer.

This is to be tested in Sauce Connect due to lack of testing infrastructure for http2 at the moment.
I added #869 to fix that.
mmatczuk added a commit that referenced this issue Jul 30, 2024
@mmatczuk
martian(h2): fix half-close propagation downstream
97907ec 
Use http2.Response.Close() to send RST_STREAM frame.
Reimplement writeFlusher as h2Writer.

This is to be tested in Sauce Connect due to lack of testing infrastructure for http2 at the moment.
I added #869 to fix that.
@mmatczuk mmatczuk modified the milestones: v1.4, v1.x Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.x
Development

No branches or pull requests
1 participant
@mmatczuk