Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting unplayable audio format disappears format selection widget #434

Closed
triplingual opened this issue Feb 23, 2024 · 3 comments
Closed
Assignees

Comments

@triplingual
Copy link

Bug Description
Format choice widget disappears for audio if an unplayable format is chosen.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the IIIF Cookbook's AV Choice recipe preview
  2. Scroll down to the Example section
  3. Click on View in Ramp
  4. In the Ramp public demo page that opens, click on the gear icon on the righthand side of the player
  5. In the format selection widget, choose mpeg2

Expected behavior
Though I don't have specific behavior I expect from Ramp, I would say generally speaking that I would expect to get the message that the file cannot be played, while keeping the format selector widget so I could play a different format

Screenshots
Initial view of format selection widget
Initial view of format selection widget

Format selection widget clicked
Format selection widget clicked

mpeg2 option clicked
mpeg2 option clicked

Player bar showing error message and absent format selection widget
Player bar showing error message and absent format selection widget

Desktop (please complete the following information):

  • MacOS 14.1.2
  • Firefox
  • 115.8.0esr

Additional context

@joncameron
Copy link
Contributor

2 issues:

  • control panel is unavailable when the player hits a stream it can't read
  • the mpeg2 file should load and play

@joncameron
Copy link
Contributor

Quality selector in Video.js handles the source change and this is outside of Ramp; will need to investigate to see what the cause of the error is.

@joncameron
Copy link
Contributor

joncameron commented Sep 10, 2024

This looks good for the error: the error message is readable, dismiss-able and much more clear to users. I'll create a new issue for the issue of the mpeg file from the IIIF cookbook example not playing.

Created #636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants