Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant Comparison Shown #84

Open
DarioS opened this issue Aug 9, 2024 · 2 comments
Open

Redundant Comparison Shown #84

DarioS opened this issue Aug 9, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@DarioS
Copy link

DarioS commented Aug 9, 2024

I have a variable with two conditions. How to do an analysis of Yes-No, but not No-Yes? I want to avoid the redundant heatmap.

contrasts_oi = "'Yes-No'")
contrast_tbl = tibble(contrast = "Yes-No", group = "Yes")
Error in multi_nichenet_analysis(allHuman, "cellType", "samples", characteristic,  : 
  conditions written in contrasts_oi should be in the condition-indicating column! This is not the case.

image

One column is the mirror image of the other column and is unnecessary. Also AREG-EGFR has no difference between Up, Down. Why?

@browaeysrobin
Copy link
Member

Hi @DarioS

Normally, you can do an analysis with only "Yes-No". The error message you got here is probably because of a typo in the contrast definition: contrasts_oi = "'Yes-No'") instead of contrasts_oi = ("'Yes-No'").

However, the main issue is the redundancy in the plot. Therefore, we will flag this issue as "enhancement" to add more flexibility in the plotting function to give users the option to make this plot non-redundant in case of 2 conditions.

@browaeysrobin browaeysrobin added the enhancement New feature or request label Aug 19, 2024
@amarinderthind
Copy link

@browaeysrobin I also have the same problem. Will this be addressed soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants