Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve error handling #35

Open
ryepup opened this issue Jan 12, 2017 · 0 comments
Open

improve error handling #35

ryepup opened this issue Jan 12, 2017 · 0 comments

Comments

@ryepup
Copy link
Owner

ryepup commented Jan 12, 2017

Improve error handling when a graph is syntactically correct but doesn't "compile", i.e. has an edge to a node that doesn't exist
ryepup added a commit that referenced this issue Jan 16, 2017
@ryepup
Add some TODOs for errors to catch
1d37b37 
refs #35
ryepup added a commit that referenced this issue Mar 11, 2017
@ryepup
Display error messages
e41f5b0 
Display the detailed error message when there's a problem.

Turns out `SParse.Syntax` is just an alias for `Error`, so I was
accidentally inheriting from it when I subclassed `Error`.

Also had to add a babel plugin for some esoteric reasons, see
https://babeljs.io/docs/usage/caveats/#classes, otherwise the jasmine
tests checking for specific error types won't work

refs #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ryepup