Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synchronization only keeps translations for first <file> container #94

Open
fabian-flassig opened this issue Jul 7, 2021 · 1 comment
Labels
effort: high Initial effort estimate: High enhancement New feature or request priority: medium Priority estimate: Medium

Comments

@fabian-flassig
Copy link

Hi,
when having an XLIFF 2.0 document with multiple containers, the synchronization of translation units will only preserve existing translations for the first container, but not for the subsequent containers.
The XLIFF documentation clearly says that the use of multiple containers is allowed (http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#d0e1524).

I guess that e.g. xlf-documents.ts line 131 simply only considers the first node:
const fileNode = this.getNode('file', this.root);

A simple example is attached; synchronization of the de-DE file will show the effect.
localization.base.zip

Resolving this would be super helpful for larger projects!

@rvanbekkum
Copy link
Owner

Dear @fabian-flassig,
Thank you for filing an issue. I will have a look on how to approach that, but indeed I think that should surely be possible to support. 😉

@rvanbekkum rvanbekkum added the enhancement New feature or request label Jul 12, 2021
@rvanbekkum rvanbekkum added the effort: high Initial effort estimate: High label Dec 10, 2021
@rvanbekkum rvanbekkum added the priority: medium Priority estimate: Medium label Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: high Initial effort estimate: High enhancement New feature or request priority: medium Priority estimate: Medium
Projects
None yet
Development

No branches or pull requests

2 participants