Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after_restore_commit undefined for v3.0 #568

Closed
noctivityinc opened this issue Oct 24, 2024 · 3 comments
Closed

after_restore_commit undefined for v3.0 #568

noctivityinc opened this issue Oct 24, 2024 · 3 comments
Assignees

Comments

@noctivityinc
Copy link

Any reason why after_restore_commit with v 3.0.0 in a Rails 7.1 app would be undefined?

The very first line of my model is:

class Idea < ActiveRecord::Base
  acts_as_paranoid after_restore_commit: true

and then I have

after_restore_commit :restore_item

But when i refresh I get:

NoMethodError (undefined method `after_restore_commit' for class Idea)
@hoylemd
Copy link

hoylemd commented Jan 17, 2025

It would appear that the support for that was actually merged after 3.0.0 was released (merged oct 2024, 3.0.0 released august 2024) That PR suggests @mathieujobin would have been responsible for releasing the next version. Is there any chance we could get a 3.0.1 published to include the after_restore_commit behaviour that's currently documented on the Readme?

@mathieujobin mathieujobin self-assigned this Jan 19, 2025
@mathieujobin
Copy link
Collaborator

released

@hoylemd
Copy link

hoylemd commented Jan 20, 2025

Awesome, thank you! I saw some of the builds failed though, is that something to be concerned about?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants