Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting points while playing results in incorrect track locations #30

Open
aganders3 opened this issue Feb 15, 2024 · 3 comments · Fixed by #95
Open

Selecting points while playing results in incorrect track locations #30

aganders3 opened this issue Feb 15, 2024 · 3 comments · Fixed by #95

Comments

@aganders3
Copy link
Collaborator

If you select points while playing, tracks show up in odd locations. I think this is because of how the selected pointIDs are calculated based on the current selected time.

@andy-sweet andy-sweet self-assigned this Mar 13, 2024
@andy-sweet andy-sweet removed their assignment Jun 5, 2024
@andy-sweet
Copy link
Collaborator

Un-assigning myself because I am not close to a good enough solution here, though some efforts (#95) may have improved the related behavior.

@aganders3
Copy link
Collaborator Author

An observation: I think this is working fine with #95 as long as the points are actually loaded. This suggests a true fix may need to be related to the stale-data prevention we have in the effect that fetches points for the new time here:
https://github.com/aganders3/points-web-viewer/blob/a3b130482a59a606e418a4e110928636c141a40e/src/components/App.tsx#L109-L111

That is, the curTime used in selection needs to be the curTime of the currently shown points, even if this fetch/set has been ignored or is in progress.

@andy-sweet
Copy link
Collaborator

I like how "it does not fix 30" closed this :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants