Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to UI framework like React/Vue #69

Open
rootCircle opened this issue Dec 19, 2024 · 3 comments
Open

Migration to UI framework like React/Vue #69

rootCircle opened this issue Dec 19, 2024 · 3 comments
Assignees
Labels
help wanted Extra attention is needed P1 size:M

Comments

@rootCircle
Copy link
Owner

This year for docFiller has been absolutely phenomenonal, from next to no use of UI to now, we at this moment use extensive UI in options and popup page for user preferences and analytics.

The common mode for UI was HTML, CSS and Vanilla JS(later typescript). But maintaining UI states using DOM is painful to manage and maintain.

So, we propose that we migrate to some framework like React, Vue etc(Open for discussion, but in Type safe variations). We have to ensure hot reloading works (in the way it is working now for Firefox and chromium).

Vitesse-webext does implement that but HMR doesnt work for Firefox for Manifest v3: https://github.com/antfu-collective/vitesse-webext! Rendering it unusable for us. We're looking for workaround in our codebase to make this happen.

This requires some changes in bundler, present under tools/ directory. Also, the change has to be incremental in nature rather than whole rewrite at once of our UI code.

Also, our code and utils will continue to exist in Typescript only!

@aprajitapandeyxcghd
Copy link

Would love to contribute to this. Can you assign me this? @rootCircle SWOC'25

@rootCircle
Copy link
Owner Author

Hi @aprajitapandeyxcghd, welcome to the docFiller repo! Since this feature request requires extensive refactoring, it is recommended that you first discuss your minimal plan and get it approved before proceeding with the implementation.

The plan should include the target framework, possible approaches to achieve this within the current codebase, and any potential drawbacks. It should also address whether this will affect the existing UI written in HTML, CSS, and TypeScript in any way. (The plan needs not to be very detailed!)

@rootCircle
Copy link
Owner Author

Join us at discord: https://discord.gg/Sa4JPe4FWT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed P1 size:M
Projects
Status: In progress
Development

No branches or pull requests

2 participants