Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] Diff between pixels #190

Open
dmiroshnyk opened this issue Aug 18, 2020 · 1 comment
Open

[IMPROVEMENT] Diff between pixels #190

dmiroshnyk opened this issue Aug 18, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@dmiroshnyk
Copy link

Moved from another issue

Why diff between pixels is calculated like (pixel2RGB - pixel1RGB)? For example, we have pixel2 - white. Diff vs pixel1 depends on pixel1 RGB color. So, diff vs red pixel will be less than vs blue. I don't understand the reason of this. For example, if I convert my image with google and change all red colors to blue and ask to recalculate diff (let's imagine the bug is fixed) - the diff percentage return another value which looks having no sense because the result file will look identically. IMHO, the diff between single pixel should be normalized to 0 (no diff) or 1(diff) and formula should look like: (<# of all different pixels> / <# of all pixels>) * 100. What do you think about it?

@dmiroshnyk dmiroshnyk added the enhancement New feature or request label Aug 18, 2020
@scp-WFZ
Copy link

scp-WFZ commented May 24, 2022

@romankh3 Hello~, I'd like to work on this issue.

@scp-WFZ scp-WFZ mentioned this issue May 24, 2022
10 tasks
scp-WFZ added a commit to scp-WFZ/image-comparison that referenced this issue May 29, 2022
//CS304 Issue link: romankh3#190
romankh3 pushed a commit to scp-WFZ/image-comparison that referenced this issue Sep 23, 2022
//CS304 Issue link: romankh3#190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants