[FR] Create repair issue with link to official login site to update EULA agreement if login fails

[magicus]

From time to time, the login fails from the integration, and the cause is that the EULA/Terms&Conditions has changed and needs to be re-agreed to, which can only be done from the app or the official web site.

This seems to be a common issue, see e.g. #662 and #683.

[edited] As suggested by @kar-who in #695 (comment), the best way to handle this would probably be to raise a repair issue, with a link to the official login page, where the EULA can be accepted.

My old suggestion was that this should be clearly stated in the error message, preferably with a direct link to where to fix it. Something like:

Login failed. This can be caused by an update to terms and conditions, try logging in using the app or https://vwid.vwgroup.io/account

Ideally, this should only be shown if there is anything in the error code from the authentication process that indicates that the T&C needs to be re-approved, but if not, I still think it would be good if this can be added as a generic help message.

[stickpin]

Thanks @magicus.
Actually, you do have this error in the logs:

        if vehicle is None:
            raise UpdateFailed(
                "Failed to update Volkswagen Connect. Need to accept EULA? "
                "Try logging in to the portal: https://www.myvolkswagen.net/"
            )

But I guess nobody really reading it. :)

[magicus]

Yeah, the logs are too invisible. It needs to be shown in the ConfigFlow. Also, the wording can be a bit more direct in saying that this is the likely cause, and the first thing the user should test in trying to resolve this.

[Moenmann]

Thank you. This helped me..I've been struggling with this regularly, but never understood how I finally made it work 😁 I've looked in some logs,but couldn't find any hints there. This should be clearer in the integration.

[femxiii]

This one too #649

[magicus]

@femxiii Do you know if 403 is returned always, and only, if the EULA is failing? If so, what you suggests in #649 is even better, to detect this specific case. But if it can't be differentiated from e.g. providing an incorrect password, then a hint is the best we can do, I guess.

[femxiii]

@magicus - It would would be a massive and hacky work around but you could use the selenium web driver to simulate the login action and check for the GDPR page (or even agree to it - though we enter dodgy grounds for consent there).

One interesting thing; my VW app still updates the car state during this time (battery % etc.). It's only when it breaks out into a browser that it requires the GDPR consent.

[kar-who]

Hey, I get really annoyed by this, too. Would it be possible to raise a repair issue, whenever this occurs?

[magicus]

What should the repair issue do? Provide a link to login with the browser?

[kar-who]

Yes, exactly. I don't check my logs all the time. But I do notice whenever there's a HA notification. And providing a link to the vw website would be the most user friendly way to fix this for now, I believe...

[magicus]

@kar-who Good point. That is probably the simplest solution as well. I changed this feature request to ask for that instead. I'll see if I can perhaps even submit a PR with that, if I can wriggle out some spare time from all my other projects I want to contribute to during the holidays. :)

[anthraxn8b]

Thanks @magicus. Actually, you do have this error in the logs:

        if vehicle is None:
            raise UpdateFailed(
                "Failed to update Volkswagen Connect. Need to accept EULA? "
                "Try logging in to the portal: https://www.myvolkswagen.net/"
            )

But I guess nobody really reading it. :)

I read it, but it seems as if I have to do the voodoo described in the original bug (changing countries, logging in and out and so on...). Maybe a link to the bug "solution" would help :-)