Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use terminal.integrated.automationProfile.windows instead of terminal.integrated.defaultProfile.windows #52

Open
Spitfire1900 opened this issue Mar 7, 2024 · 3 comments

Comments

@Spitfire1900
Copy link

I use Xonsh on Windows and unless I set "terminal.integrated.defaultProfile.windows": "Command Prompt" (or Powershell) the program behaves as if it is on Linux, however this causes a The specified path is invalid.

fzf | c:\\Users\\XXXXXX\\.vscode\\extensions\\rlivings39.fzf-quick-open-0.5.1\\scripts\\topipe.bat open \\\\?\\pipe\\fzf-pipe-51676
The specified path is invalid.
@rlivings39
Copy link
Owner

Thanks for reporting @Spitfire1900 . Please let me know if I'm understanding correctly. As I understand this, you're reporting 2 issues.

First, you have terminal.integrated.automationProfile.windows set but not terminal.integrated.defaultProfile.windows. The extension reads the latter and ignores the former, causing issues. Second, once you set defaultProfile you get the error shown.

Is that accurate or am misunderstanding?

@Spitfire1900
Copy link
Author

That is correct.

  • I have terminal.integrated.defaultProfile.windows set to a custom Xonsh profile.
  • This extension doesn't seem to work well with Xonsh on windows.
  • I also have terminal.integrated.automationProfile.windows set to:
"terminal.integrated.automationProfile.windows": {
    "path": "C:\\Windows\\System32\\cmd.exe",
    "icon": "terminal-cmd"
}
  • The extension is using terminal.integrated.defaultProfile.windows instead of terminal.integrated.automationProfile.windows.
  • The extension adding support for Xonsh or using the terminal.integrated.automationProfile.windows instead of terminal.integrated.defaultProfile.windows would resolve this issue.

@rlivings39
Copy link
Owner

Great. Thanks for confirming @Spitfire1900 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants