Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task: Refactor homepage hero banner using DaisyUI hero component #149

Open
saltyypanda opened this issue Sep 8, 2024 · 1 comment
Open
Assignees
Labels

Comments

@saltyypanda
Copy link
Contributor

saltyypanda commented Sep 8, 2024

Description

For maintainability and aesthetic purposes, let's see if we can use DaisyUI's hero component for our homepage hero section

@saltyypanda saltyypanda converted this from a draft issue Sep 8, 2024
@saltyypanda saltyypanda added the good first issue Good for newcomers label Oct 20, 2024
@AriasLcr AriasLcr self-assigned this Oct 30, 2024
@AriasLcr
Copy link
Contributor

AriasLcr commented Nov 3, 2024

Pre-changes

Image

Post-refactoring using DaisyUI Hero Component

In short, the biggest change is in the horizontal margin/padding which imo looks less cluttered.

The DaisyUI template includes a solid background color, which highlights the component and makes it distinct. Currently, our page doesn’t use many solid colors to separate sections, which might make it harder for users to distinguish between different components. How could we adjust the visual structure to improve the clarity and flow between sections?

Modern pages often use either a background image or a solid background color to clearly distinguish the hero component. Incorporating a similar approach could help users instantly recognize the hero section and provide a stronger visual hierarchy for the page.

I'll bring this up to the UX Design team. Other than that, this issue can be closed. I'm opening a PR.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Review
Development

No branches or pull requests

2 participants