Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove this fork and rewrite a new library for this. #8

Open
rishichawda opened this issue Apr 11, 2019 · 6 comments
Open

Remove this fork and rewrite a new library for this. #8

rishichawda opened this issue Apr 11, 2019 · 6 comments

Comments

@rishichawda
Copy link
Owner

This code is shit. Remove everything, rewrite and publish as v1.1 under the react-native-qrcode-generator package name.

@gitstud
Copy link

gitstud commented Mar 10, 2020

@rishichawda Let me know if you'd like help with that :)

@rishichawda
Copy link
Owner Author

@gitstud I would appreciate it very much but I am not getting time myself to work on this. I will notify you as soon as I start! Fingers crossed for this weekend. 🤞

@rishichawda rishichawda added help wanted Extra attention is needed and removed 🔥 High priority 🔥 help wanted Extra attention is needed labels Apr 18, 2020
@douglasjunior
Copy link

I would recommend the React Native QRCode SVG, as it renders native Views without the need for workarounds with canvas and webview.

@rishichawda
Copy link
Owner Author

Thanks for the recommendation. I have used that one before. Part of the reason why I had forked and maintained this was because I needed to use it in one of the projects and needed to generate a plain QRCode, nothing fancy. react-native-qrcode-svg library comes with other functionalities which I didn't need. That means it comes with the additional code that I didn't need. Hence, this.

@douglasjunior
Copy link

douglasjunior commented Aug 23, 2020

SVG overhead is much less than the version using webview.

The react-native-qrcode-svg just use the qrcode to generate the paths and then converts the paths to use the react-native-svg, it is a very lean implementation, there is no extra code or workarounds like in webview version that uses canvas and web others web technologies.

Think, with webview you need to load an entire browser just to display a QR code image.

@rishichawda
Copy link
Owner Author

As I have said earlier, this was forked for a project where I needed a simple QRCode view. That project already had a WebView. So this was the best option for that project. I'm aware of the internal implementation of the library you have mentioned and would undoubtedly use for other projects where it seems fit. I'm also mindful of how badly this library is doing this. Hence this issue was created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants