Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note creation modal #427

Open
joseplayero opened this issue Oct 5, 2024 · 8 comments
Open

Remove note creation modal #427

joseplayero opened this issue Oct 5, 2024 · 8 comments

Comments

@joseplayero
Copy link
Collaborator

Problem

when creating a note, a modal opens to name the file for that note first before creating it.

Solution

Instead editor should open instantly (without opening modal) and the note should only be created only once there is content to be saved. The behaviour should be the same as obsidian.

  • The naming of the note should be using either the markdown title (if the user types one) ensuring an hashes are removed from the note name.
  • If the user does not type a markdown title, the first 20 characters should be used to name a new note.
  • There will need to be automatic removal of characters that are not valid in a filename (make sure you use the same function in the create note modal)
  • i'd recommend modifying the writeEditorContentToDisk function (or something similar) so that if a filepath is not provided, it is generated automatically. But make sure to check no other code is broken that calls the same function

Contributing

please comment that you will attempt this before starting. A developer will then be assigned to this task. High quality, high readability code will receive a tip. Low quality code will not be accepted and a new developer will be assigned to the task.

@joseplayero
Copy link
Collaborator Author

/bounty $25

Copy link

algora-pbc bot commented Oct 5, 2024

💎 $25 bounty • reorproject

Steps to solve:

  1. Start working: Comment /attempt #427 with your implementation plan
  2. Submit work: Create a pull request including /claim #427 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to reorproject/reor!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @ezhil56x Oct 5, 2024, 11:18:54 AM #431
🟢 @Bhavyajain21 Oct 5, 2024, 11:21:02 AM WIP
🟢 @iamhvsharma Oct 5, 2024, 4:18:15 PM WIP

@ezhil56x
Copy link
Contributor

ezhil56x commented Oct 5, 2024

/attempt #427

Algora profile Completed bounties Tech Active attempts Options
@ezhil56x 49 bounties from 13 projects
JavaScript, TypeScript,
Java & more
Cancel attempt

@Bhavyajain21
Copy link
Collaborator

Bhavyajain21 commented Oct 5, 2024

/attempt #427

Can I be assigned?

Algora profile Completed bounties Tech Active attempts Options
@Bhavyajain21 15 bounties from 3 projects
Rust, TypeScript,
JavaScript & more
Cancel attempt

@joseplayero
Copy link
Collaborator Author

please go ahead @ezhil56x as you commented first

@iamhvsharma
Copy link

iamhvsharma commented Oct 5, 2024

/attempt #427

Copy link

algora-pbc bot commented Oct 5, 2024

💡 @ezhil56x submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Oct 10, 2024

🎉🎈 @ezhil56x has been awarded $25! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants