hostRules in inherited config being ignored

[sichapman]

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab

Please tell us more about your question or problem

Any hostRules in the inherited config file are completely ignored.
I suspect it may be because inherited.ts is missing the equivalent of this block that actually registers them
https://github.com/renovatebot/renovate/blob/main/lib/workers/repository/init/merge.ts#L252-L268

I tried copying it into inherited.ts and the inherited hostRules started being registered and respected.

(Difficult to come up with a minimal repro that would actually use hostRules in a visible way)

Logs (if relevant)

No response

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[rarkins]

Please create a reproduction with dummy hostRules with inheritConfig. This will be enough for us to debug the problem and confirm the solution once fixed

[rlatapy-luna]

I encountered the same issue with Github mend app. If I put my hostRules in my-org/renovate-config, these are ignored. Same rules in the repo conf works.

[xavier-calland]

Hi
I have the same problem with a self-hosted Renovate instance with Gerrit.

Reproduction repo with some notes : https://github.com/xavier-calland/renovate-reproduction-d31461-inherited

This was working with Renovate <= 39.63.0

I think this commit is the cause of the change in behavior.

[rarkins]

Hi, I appreciate all the work in the reproduction, and it may help, but unfortunately if we are not able to run the reproduction ourselves then it means we can't debug it.

[xavier-calland]

Ok
What can I do to help you reproduce?
Creating a full Github environment? (inherited config + command to launch Renovate + what to search in the log messages indicating hostrules are used or not)

[rarkins]

Yes, if it reproduces entirely on github.com then I'd be able to run it and debug it. Shouldn't it require just an inherit config with hostRules plus an empty repo config?

[rarkins]

@RahulGautamSingh can you try to debug/fix this from code inspection?

[RahulGautamSingh]

Debugged. It's true we do not set the hostRules from the inherited config.

We set the host rules before merging the inherited and repo config.

Moving host rule setting part in the mergeRenovateConfig fn after inherited & repo config are merged, should fix this.

Or We could set host rules while resolving the inherited config itself.

[rarkins]

Just be careful for when the hostRules.clear() calls are made, so that inherited rules aren't ever wiped unintentionally