Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid assignments in SV backend #867

Open
lexbailey opened this issue Jan 9, 2025 · 0 comments
Open

Invalid assignments in SV backend #867

lexbailey opened this issue Jan 9, 2025 · 0 comments

Comments

@lexbailey
Copy link
Contributor

I think there might be a bug in the SV generation. Below is an example from RISC-V.

I see generated code like the module below, where there is a few instances of the same problem.
For example: zz495_2 has type sail_unit, but then it is assigned the value {SAIL_UNIT, s_0}, which has the type {sail_unit, sail_unit}, which fails to type check.

module zinternal_errorzIB32zK(
    input sail_unit file_0 /* file */, 
    input logic [127:0] line_0 /* line */, 
    input sail_unit s_0 /* s */, 
    input bit zassert_reachablez3 /* assert_reachable */, 
    output logic [31:0] sail_return,
    output bit sail_have_exception /* have_exception */, 
    output t_exception sail_current_exception /* current_exception */
);
    sail_unit zz490_2;
    sail_unit zz492_2;
    sail_unit zz493_2;
    sail_unit zz494_2;
    sail_unit zz495_2;
    always_comb begin
        zz494_2 = sail_dec_str_zz5i(line_0);
        zz495_2 = {SAIL_UNIT, s_0};
        zz493_2 = {zz494_2, zz495_2};
        zz492_2 = {SAIL_UNIT, zz493_2};
        zz490_2 = {file_0, zz492_2};
        begin
            if (!zassert_reachablez3); else $fatal(zz490_2);
        end;
    end;
endmodule

Is this expected? It happens in lots of places in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant