diff --git a/src/ReactDOM.re b/src/ReactDOM.re index 42b3a5777..ecc27cb7f 100644 --- a/src/ReactDOM.re +++ b/src/ReactDOM.re @@ -489,7 +489,7 @@ module Ref = { }; /* This list isn't exhaustive. We'll add more as we go. */ -[@deriving abstract] +[@deriving (jsProperties, getSet)] type domProps = { [@mel.optional] key: option(string), diff --git a/src/ReactDOM.rei b/src/ReactDOM.rei index d6cbd26d4..0d80a6a92 100644 --- a/src/ReactDOM.rei +++ b/src/ReactDOM.rei @@ -490,7 +490,7 @@ module Ref: { }; /* This list isn't exhaustive. We'll add more as we go. */ -[@deriving abstract] +[@deriving (jsProperties, getSet)] type domProps = { [@mel.optional] key: option(string), diff --git a/src/ReactDOMServerNode.re b/src/ReactDOMServerNode.re index 3d00c0121..eea22122b 100644 --- a/src/ReactDOMServerNode.re +++ b/src/ReactDOMServerNode.re @@ -1,4 +1,4 @@ -[@deriving abstract] +[@deriving (jsProperties, getSet)] type options = { [@mel.optional] bootstrapScriptContent: option(string), diff --git a/src/ReactDOMServerNode.rei b/src/ReactDOMServerNode.rei index c1cef959e..2153fbfee 100644 --- a/src/ReactDOMServerNode.rei +++ b/src/ReactDOMServerNode.rei @@ -1,4 +1,4 @@ -[@deriving abstract] +[@deriving (jsProperties, getSet)] type options = { [@mel.optional] bootstrapScriptContent: option(string), @@ -45,5 +45,4 @@ let renderToPipeableStream: ~progressiveChunkSize: int=?, React.element ) => - pipeableStream; diff --git a/test/React__test.re b/test/React__test.re index 3e2f77717..b96e9da61 100644 --- a/test/React__test.re +++ b/test/React__test.re @@ -24,7 +24,7 @@ module DummyComponentThatMapsChildren = { {children->React.Children.mapWithIndex((element, index) => { React.cloneElement( element, - {"key": {j|$index|j}, "data-index": index}, + {"key": string_of_int(index), "data-index": index}, ) })} ; @@ -133,7 +133,9 @@ describe("React", () => { let container = getContainer(container); let array = [|1, 2, 3|] - ->Array.map(item => {