Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SyntaxError in generated settings.json #84

Open
paulober opened this issue Jul 3, 2023 · 2 comments
Open

SyntaxError in generated settings.json #84

paulober opened this issue Jul 3, 2023 · 2 comments

Comments

@paulober
Copy link
Contributor

paulober commented Jul 3, 2023 •
edited
Loading

The updated settings.json content in the update_vscode_json_to_sdk1_5 branch contains a ) where I should not be.

pico-project-generator/pico_project.py

Line 1240 in 2ab988c

' "C_Cpp.default.configurationProvider": "ms-vscode.cmake-tools")\n'

Also following additional , causes JSON.parse to fail:

SyntaxError: Expected double-quoted property name in JSON at position 247

pico-project-generator/pico_project.py

Line 1233 in 2ab988c

' },\n'

paulober added a commit to paulober/pico-project-generator that referenced this issue Jul 3, 2023
@paulober
Fix raspberrypi#84, SyntaxError in generated settings.json
751b2f5
paulober added a commit to paulober/pico-project-generator that referenced this issue Jul 3, 2023
@paulober
Fix raspberrypi#84, SyntaxError in generated settings.json
56666ce
@paulober paulober mentioned this issue Jul 3, 2023
Merged
JamesH65 pushed a commit that referenced this issue Jul 4, 2023
@paulober
Fix #84, SyntaxError in generated settings.json (#85)
2f3efc5
@lurch
Copy link
Contributor

lurch commented Jul 6, 2023

Fixed by #85 , so can be closed?

@paulober
Copy link
Contributor Author

paulober commented Jul 6, 2023

@lurch Yes. Github has not closed it automatically because it waits for the feature branch to be merged into master.

t1mc0rd35 pushed a commit to t1mc0rd35/pico-project-generator that referenced this issue Oct 13, 2023
@paulober @t1mc0rd35
Fix raspberrypi#84, SyntaxError in generated settings.json (raspber…
feecbc3 
…rypi#85)
t1mc0rd35 pushed a commit to t1mc0rd35/pico-project-generator that referenced this issue Oct 13, 2023
@paulober @t1mc0rd35
Fix raspberrypi#84, SyntaxError in generated settings.json (raspber…
186d1bf 
…rypi#85)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lurch @paulober