From 6e2f44176e41c0784a6faa30925e840d2aa320f4 Mon Sep 17 00:00:00 2001 From: Naoki Kanazawa Date: Wed, 10 Jan 2024 11:10:46 +0900 Subject: [PATCH] Wording suggestions Co-authored-by: Will Shanks --- .../library/characterization/analysis/t1_analysis.py | 4 ++-- qiskit_experiments/library/characterization/t1.py | 6 +++--- test/library/characterization/test_stark_p1_spect.py | 6 +++--- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/qiskit_experiments/library/characterization/analysis/t1_analysis.py b/qiskit_experiments/library/characterization/analysis/t1_analysis.py index d42867a950..e7196a17eb 100644 --- a/qiskit_experiments/library/characterization/analysis/t1_analysis.py +++ b/qiskit_experiments/library/characterization/analysis/t1_analysis.py @@ -270,7 +270,7 @@ def estimate_minmax_frequencies( coefficients: Dict[str, float], max_amplitudes: Tuple[float, float] = (-0.9, 0.9), ) -> Tuple[float, float]: - """Inquire maximum and minimum Stark shfit available within specified amplitude range. + """Inquire maximum and minimum Stark shift available within specified amplitude range. Args: coefficients: A dictionary of Stark coefficients. @@ -286,7 +286,7 @@ def estimate_minmax_frequencies( if any(missing): raise KeyError( "Following coefficient data is missing in the " - f"'stark_coefficients' dictionary: {missing}." + f"stark 'coefficients' dictionary: {missing}." ) names = cls.stark_coefficients_names # alias diff --git a/qiskit_experiments/library/characterization/t1.py b/qiskit_experiments/library/characterization/t1.py index 5b3891f1e5..1ba3cadcfd 100644 --- a/qiskit_experiments/library/characterization/t1.py +++ b/qiskit_experiments/library/characterization/t1.py @@ -223,9 +223,9 @@ def _default_experiment_options(cls) -> Options: convert tone amplitudes into amount of Stark shift. This dictionary must include all keys defined in :attr:`.StarkP1SpectAnalysis.stark_coefficients_names`, which are calibrated with :class:`.StarkRamseyXYAmpScan`. - Alternatively, it searches for these coefficients in the result database - when "latest" is set. This requires having the experiment service set in - the experiment data to analyze. + Alternatively, a search for these coefficients in the result database is run + when "latest" is set. This requires having the experiment service available + in the ``backend`` set for the experiment. """ options = super()._default_experiment_options() options.update_options( diff --git a/test/library/characterization/test_stark_p1_spect.py b/test/library/characterization/test_stark_p1_spect.py index 0989f4512b..3ae4c17e76 100644 --- a/test/library/characterization/test_stark_p1_spect.py +++ b/test/library/characterization/test_stark_p1_spect.py @@ -146,9 +146,9 @@ def test_scanning_frequency(self, po1, po2, po3, no1, no2, no3, ferr): """Test scanning frequency with experiment service. This is a sort of round-trip test. - We generate amplitude from frequency through experimetn class. - this amplitude is converted into frequency again with the same coefficients. - Two frequencies must be consistent. + We generate amplitudes from frequencies through the experiment class. + These amplitudes are converted into frequencies again with the same coefficients. + The two sets of frequencies must be consistent. """ service = self.create_service_helper(po1, po2, po3, no1, no2, no3, ferr, 0, "fake_hanoi")