From 484ca0bd6776364709e453cad381025d2271b52b Mon Sep 17 00:00:00 2001 From: Nyall Dawson Date: Thu, 10 Oct 2024 08:56:59 +1000 Subject: [PATCH] Don't override cursor in pin labels map tool This tool was setting the application cursor after every map render. It's unnecessary and impolite, and causes bad UX. Fixes #59016 --- src/app/labeling/qgsmaptoolpinlabels.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/app/labeling/qgsmaptoolpinlabels.cpp b/src/app/labeling/qgsmaptoolpinlabels.cpp index e8c03ef20cb6..a9fc6820eb89 100644 --- a/src/app/labeling/qgsmaptoolpinlabels.cpp +++ b/src/app/labeling/qgsmaptoolpinlabels.cpp @@ -190,7 +190,6 @@ void QgsMapToolPinLabels::highlightPinnedLabels() const QList labelPosList = labelingResults->labelsWithinRect( ext ); - QApplication::setOverrideCursor( Qt::WaitCursor ); for ( const QgsLabelPosition &pos : labelPosList ) { mCurrentLabel = LabelDetails( pos, canvas() ); @@ -254,18 +253,15 @@ void QgsMapToolPinLabels::highlightPinnedLabels() highlightCallout( false, callout, calloutStringID, calloutColor ); } } - QApplication::restoreOverrideCursor(); } void QgsMapToolPinLabels::removePinnedHighlights() { - QApplication::setOverrideCursor( Qt::BusyCursor ); for ( QgsRubberBand *rb : std::as_const( mHighlights ) ) { delete rb; } mHighlights.clear(); - QApplication::restoreOverrideCursor(); } void QgsMapToolPinLabels::pinUnpinLabels( const QgsRectangle &ext, QMouseEvent *e )