Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]cars mods dont save when u take out of garage #349

Open
ararobo1 opened this issue Feb 7, 2024 · 9 comments
Open

[BUG]cars mods dont save when u take out of garage #349

ararobo1 opened this issue Feb 7, 2024 · 9 comments
Labels
bug Something isn't working Stale

Comments

@ararobo1
Copy link

ararobo1 commented Feb 7, 2024

Describe the bug
A clear and concise description of what the bug is. A stranger to qbcore should be able to read your bug report and understand how to reproduce it themselves and understand how the feature should work normally.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Use this item '....' (item's name from shared.lua if applicable)
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Questions (please complete the following information):

  • When you last updated: [e.g. last week] today
  • Are you using custom resource? which ones? [e.g. zdiscord, qb-target] qb-core, qb-mechanicjob, and qb-garages
  • Have you renamed qb- to something custom? [e.g. yes/no] no

Additional context
Add any other context about the problem here.

@ararobo1 ararobo1 added the bug Something isn't working label Feb 7, 2024
@Kraslichh
Copy link

same error pls fix it

@Craziebird
Copy link

same still going on

@IRedSea0
Copy link

did you guys fix it

@Qwerty1Verified
Copy link
Contributor

Can you please add some more information to this about how to reproduce the issue? From what it sounds, you own a vehicle, you modified it, you stored it in a garage, you took the vehicle out, it had no mods. Is this how to reproduce the issue?

@Pixlebun
Copy link

Since we are experiencing a similar issue I can hopefully provide a bit more information on how to reproduce it. When a player modifies their vehicle, this is both cosmetically and also car upgrades (engine mods, armour, suspension etc), once stored in the garage the information is saving correctly. However, once a player takes the vehicle out the mods are disappearing.

From what we can see it appears to be a loading issue. Sometimes the vehicle can take 5 or more seconds to load in all the mods that should be applied to the vehicle. But a player can interact with the vehicle the second it comes out. Once a player interacts with the vehicle it will not load them in further, so the mods "disappear".

Possibly an option to make the car un-interactable for a set amount of time as it loads in might be a solution if loading mods in quickly can't be fixed?

Hope this helps you reproduce the bug!

@Qwerty1Verified
Copy link
Contributor

Thank you for the information, I'll do some testing and get a PR pushed through.

@LettyR
Copy link

LettyR commented Jul 7, 2024

Simiular issue on my end.
I use Renzu Projectcars. When a "projectcar" get trough Jim Mechanic and get parked, it comes out without Mods.
When I buy a vehicle from qb-vehicleshop and this Car go trough Jim Mechanic, I can puul it out of the Garage and all Mods are there.
First we think it´s an Issue with the Plate - cause Projectcars were build "xx xx" and pdm cars with "xxxxxx".
Soo - we change the plate - no changes at the Issue at all.
Then we search in Renzu script - inthere the vehicle should saved in "owned_vehicles" - but they go all in player_vehicles.
Then we look at the Jim Mechanic - all exports done, every change on a Car Server say: " [ script:jim-mechanic] Debug: updateVehicle: Vehicle Mods - [3VV243KM] "
Everything how it should be.

Leaves us scratching our Heads - any Clue what could cuased this ?

@martink1337
Copy link

same here with me, when vehicle is tuned, for example color changed with qb-customs. Add in garage, take out in garage and the tunning is gone

Copy link

This issue has had 60 days of inactivity & will close within 7 days

@github-actions github-actions bot added the Stale label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Stale
Projects
None yet
Development

No branches or pull requests

8 participants