Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined behavior of calculate_HH for sequences with undefined particles #2

Open
pm-blanco opened this issue Feb 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@pm-blanco
Copy link
Collaborator

The current implementation of calculate_HH breaks if the molecule has undefined particles on its residue_list. This becomes inconvenient if the user wants to use the function in plotting scripts for molecules with many types of different particle types because then one needs to define dummy particles in pyMBE for such particles instead of simply passing a pka_set.

See handy_scripts/plot_HH.py
Suggested behaviour: The function should ignore particles not defined in the pmb.df for the calculation of the HH curve but it should print a warning to terminal to inform the user that such particles have been ignored.

@pm-blanco pm-blanco added the bug Something isn't working label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant