Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advanced search combobox: copy, rather than move, selected values to the top #4675

Open
10 of 11 tasks
sandbergja opened this issue Jan 2, 2025 · 1 comment · May be fixed by #4715
Open
10 of 11 tasks

Advanced search combobox: copy, rather than move, selected values to the top #4675

sandbergja opened this issue Jan 2, 2025 · 1 comment · May be fixed by #4715
Assignees
@rladdusaw
Labels
bug 🐛 The application does not work as expected because of a defect user experience Tickets related to user experience

Comments

@sandbergja
Copy link
Member

sandbergja commented Jan 2, 2025 •
edited by rladdusaw
Loading

Current display

When the user selects an option from the combobox, it disappears from its current location and moves to the top of the screen.

Desired display

When the user selects an option, it keeps its place, but is also copied to the top. See this prototype for the behavior.

Acceptance criteria

  • When the user selects an option, it keeps its place
  • When the user selects an option, it is copied to the top
  • There is a separation between the selected options at the top and the list of all options below
  • When the user de-selects an option, it is removed from the top and keeps its place in the list below
  • We do not re-sort items when options are selected
  • Rename pul to "All Princeton Holdings"
  • When "All Princeton Holdings" option is selected, it is at the top of the selected options.
  • PUL holding libraries appear in the menu first before the more specific locations.
  • When "All Princeton Holdings" option is not selected, it is at the top of the unselected options.
  • I can successfully use this feature with Voice Over in Safari.
  • I have checked this feature using one of the following browser extensions and confirmed that it does not add any level A or level AA issues:
    • axe dev tools
    • Lighthouse
    • Wave
@sandbergja sandbergja added the user experience Tickets related to user experience label Jan 2, 2025
This was referenced Jan 2, 2025
Closed
Closed
@kevinreiss kevinreiss added the bug 🐛 The application does not work as expected because of a defect label Jan 2, 2025
@rladdusaw rladdusaw self-assigned this Jan 16, 2025
@rladdusaw rladdusaw linked a pull request Jan 21, 2025 that will close this issue
Open
@kevinreiss
Copy link
Member

Do we need to make another issue for the voice over test? Or is that somehting you want some help testing @rladdusaw?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rladdusaw rladdusaw

Labels
bug 🐛 The application does not work as expected because of a defect user experience Tickets related to user experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Copy seleced items instead of moving to the top pulibrary/orangelight
3 participants
@kevinreiss @sandbergja @rladdusaw