New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race Condition - Synchronise event: Force push on approved PR leads to merge rather than retests #1219

Open

vipulgupta2048 opened this issue Oct 17, 2024 · 0 comments

Assignees

Member

vipulgupta2048 commented Oct 17, 2024 •

edited

Loading

PR: balena-io/docs#3084

Scenario:

A pushed a test commit on an auto-merge PR
A approved the PR. PR doesn't get merged since A has committed on it.
B removed A's test commit and force push.
Instead of tests running again, a race condition happens, all conditions get met and the PR merges immediately.

Problem

My force push created a synchronized event that didn't get tested again; instead, the PR was merged.

Downloaded Logs

Synchronize event didn't finish due to race condition:
logs_29694248838.zip | https://github.com/balena-io/docs/actions/runs/11366382108/job/31616690787
Closed event right after it as the PR merged:
logs_29694250989.zip https://github.com/balena-io/docs/actions/runs/11363520188

vipulgupta2048 assigned klutchell and vipulgupta2048

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment