From 513fef0b59b5d1489f7a7eef206198b1c287a408 Mon Sep 17 00:00:00 2001 From: Eduard S Date: Thu, 27 Jun 2024 14:24:58 +0000 Subject: [PATCH 1/2] fix: make lookup-any-sanity-checks optional in halo2_proofs --- halo2_proofs/Cargo.toml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/halo2_proofs/Cargo.toml b/halo2_proofs/Cargo.toml index 96f84d7bb..e5607f6b9 100644 --- a/halo2_proofs/Cargo.toml +++ b/halo2_proofs/Cargo.toml @@ -42,8 +42,8 @@ harness = false [dependencies] halo2_middleware = { path = "../halo2_middleware" } -halo2_backend = { path = "../halo2_backend" } -halo2_frontend = { path = "../halo2_frontend" } +halo2_backend = { path = "../halo2_backend", default-features = false } +halo2_frontend = { path = "../halo2_frontend", default-features = false } halo2curves = { version = "0.6.1", default-features = false } rand_core = { version = "0.6", default-features = false, features = ["getrandom"] } plotters = { version = "0.3.0", default-features = false, optional = true } From eaaefe1be606ddfb9b16051722bfce9ad66ea3e7 Mon Sep 17 00:00:00 2001 From: Eduard S Date: Thu, 27 Jun 2024 14:43:33 +0000 Subject: [PATCH 2/2] fix: bad lookup tests only when feature --- halo2_frontend/src/dev.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/halo2_frontend/src/dev.rs b/halo2_frontend/src/dev.rs index 438648a18..2958a3202 100644 --- a/halo2_frontend/src/dev.rs +++ b/halo2_frontend/src/dev.rs @@ -1495,6 +1495,7 @@ mod tests { ); } + #[cfg(feature = "lookup-any-sanity-checks")] #[test] #[should_panic( expected = "pair of tagging expressions(query of the tag columns or mutiple query combinations) should be included" @@ -1578,6 +1579,7 @@ mod tests { .unwrap(); } + #[cfg(feature = "lookup-any-sanity-checks")] #[test] #[should_panic(expected = "all table expressions need selector/fixed query for tagging")] fn bad_lookup_any_no_fixed_col_or_selector() { @@ -1652,6 +1654,7 @@ mod tests { .unwrap(); } + #[cfg(feature = "lookup-any-sanity-checks")] #[test] #[should_panic( expected = "all table expressions contain only fixed query, should use `lookup` api instead of `lookup_any`"