-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Illegal size param in the bid request for the interstitial ad units #391
Labels
Comments
@YuriyVelichkoPI is this still relevant? |
@ValentinPostindustria @OlenaPostindustria , please check if this behavior is still actual. If I remember correctly, we made some changes to interstitial bid requests. |
github-project-automation
bot
moved this from Under Review
to Done
in Prebid Mobile Prioritization
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
One of the demand partners complains about ad requests with unsupported ad sizes: 360x728, 320x637, 392x776, etc.
The reason is that prebid SDK sends the device size in
imp.banner.format[0]
.If the publisher sets the size in the stored impression it will be overridden with the size from the bid request. It means that
imp.banner.format[0]
will never be changed and will always reflect the device size.According to the PBS logic, if the publisher sets the size like
1x1
the server will place the device size into the final bid request.https://github.com/prebid/prebid-server/blob/d384e91bf99f886927a2bd412fd439502a1de088/endpoints/openrtb2/interstitial.go#L41
Workaround
There is a workaround here. If the publisher set the
minWidthPerc
andminHeightPrec
the PBS will generate a range of acceptable sizes and put it into the bid request. In a result, the demand partner will receive several sizes in theimp.banner.format
.Objective
There is only one requirement here to fix the wrong logic:
imp.banner.format[0]
for interstitial ads.The text was updated successfully, but these errors were encountered: