From df1f20d5eaf9fa1f39a8251e41321ecf3b53d78d Mon Sep 17 00:00:00 2001
From: Ryan Christian <33403762+rschristian@users.noreply.github.com>
Date: Tue, 31 Dec 2024 13:31:30 -0600
Subject: [PATCH] refactor: Remove `generic` aria role from types (#4610)

---
 src/jsx.d.ts                    | 1 -
 test/ts/dom-attributes-test.tsx | 4 ++++
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/jsx.d.ts b/src/jsx.d.ts
index 8e7f9db1f1..e08448b595 100644
--- a/src/jsx.d.ts
+++ b/src/jsx.d.ts
@@ -1096,7 +1096,6 @@ export namespace JSXInternal {
 		| 'feed'
 		| 'figure'
 		| 'form'
-		| 'generic'
 		| 'grid'
 		| 'gridcell'
 		| 'group'
diff --git a/test/ts/dom-attributes-test.tsx b/test/ts/dom-attributes-test.tsx
index 57fda6949d..edf922e752 100644
--- a/test/ts/dom-attributes-test.tsx
+++ b/test/ts/dom-attributes-test.tsx
@@ -34,6 +34,10 @@ const signalValidAriaValues2 = (
 );
 
 const validRole = <div role="button" />;
+// @ts-expect-error We should correctly type aria roles
+const invalidRole = <div role="invalid-role" />;
+// @ts-expect-error We should disallow `generic` as it should not ever be explicitly set
+const invalidRole2 = <div role="generic" />;
 const fallbackRole = <div role="none presentation" />;
 
 const booleanishTest = (