Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default log level in Code / Positron is "null" #147

Open
lionel- opened this issue Jan 13, 2025 · 2 comments
Open

Default log level in Code / Positron is "null" #147

lionel- opened this issue Jan 13, 2025 · 2 comments

Comments

@lionel-
Copy link
Collaborator

lionel- commented Jan 13, 2025

I guess this is not expected that the default is "null"?

Image
@DavisVaughan
Copy link
Collaborator

DavisVaughan commented Jan 13, 2025

I think that's right actually? On the server side we want to know if the user actually set the value on the client side or not, so it needs to be optional on the client side.

It's specified like this in the package.json

Image

I think it ends up as a null or undefined on the typescript side, and is serialized to Rust as a None

@lionel-
Copy link
Collaborator Author

lionel- commented Jan 14, 2025

Is this just so that the server provides a default value and not the client?

I would just duplicate the default on the client side. This null value is puzzling as it looks like a bug and doesn't inform what is the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants