Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simpler approach for storing and accessing document settings #143

Open
lionel- opened this issue Jan 10, 2025 · 0 comments
Open

Simpler approach for storing and accessing document settings #143

lionel- opened this issue Jan 10, 2025 · 0 comments

Comments

@lionel-
Copy link
Collaborator

lionel- commented Jan 10, 2025

Follow up on #122.

  • We currently have a setting resolver that caches settings for the folders in the workspace.

  • We don't store resolved settings in our Document objects to avoid unnecessary copies of data. Nor do we store references because we'd have to deal with lifetimes and invalidation.

That might be a good use case for trying out caching with Salsa. We could then simply store the settings in every document since they'd be interned and cached by Salsa, which would also handle invalidation. We'd spare a bunch of code and have better ergonomics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant