Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eigen includes should not contain version prefix #33

Open
gavanderhoorn opened this issue Nov 5, 2017 · 1 comment
Open

Eigen includes should not contain version prefix #33

gavanderhoorn opened this issue Nov 5, 2017 · 1 comment

Comments

@gavanderhoorn
Copy link
Contributor

The current #includes seem to have the eigen3 part included:

https://github.com/shaun-edwards/moveit_simple/blob/2bcca7d855c199883963c81b4f6668b060533401/moveit_simple/include/moveit_simple/moveit_simple.h#L28

That is rather unusual, and will limit future compatibility with (if it ever gets released) v4 of Eigen.

Was this done to work around incorrectly setup include paths (ie: only /usr/include on the path)?

@MauleshSTrivedi
Copy link
Contributor

@gavanderhoorn Good catch. It was definitely a part of an old commit, but I'm not sure why this was done specifically. I can make the necessary changes once I have more information regarding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants