go get -u -v upgrade to v0.14.0 break change

[suconghou]

before update

require (
	github.com/gorilla/websocket v1.5.0
	github.com/pion/webrtc/v3 v3.1.48
	github.com/tidwall/gjson v1.14.3
	golang.org/x/net v0.2.0
)

require (
	github.com/google/uuid v1.3.0 // indirect
	github.com/pion/datachannel v1.5.2 // indirect
	github.com/pion/dtls/v2 v2.1.5 // indirect
	github.com/pion/ice/v2 v2.2.11 // indirect
	github.com/pion/interceptor v0.1.12 // indirect
	github.com/pion/logging v0.2.2 // indirect
	github.com/pion/mdns v0.0.5 // indirect
	github.com/pion/randutil v0.1.0 // indirect
	github.com/pion/rtcp v1.2.10 // indirect
	github.com/pion/rtp v1.7.13 // indirect
	github.com/pion/sctp v1.8.3 // indirect
	github.com/pion/sdp/v3 v3.0.6 // indirect
	github.com/pion/srtp/v2 v2.0.10 // indirect
	github.com/pion/stun v0.3.5 // indirect
	github.com/pion/transport v0.13.1 // indirect
	github.com/pion/turn/v2 v2.0.8 // indirect
	github.com/pion/udp v0.1.1 // indirect
	github.com/tidwall/match v1.1.1 // indirect
	github.com/tidwall/pretty v1.2.1 // indirect
	golang.org/x/crypto v0.3.0 // indirect
	golang.org/x/sys v0.2.0 // indirect
)

use go get -u -v update all pion to latest , get

go: upgraded github.com/pion/ice/v2 v2.2.11 => v2.2.12
go: upgraded github.com/pion/transport v0.13.1 => v0.14.0
go: upgraded github.com/pion/webrtc/v3 v3.1.48 => v3.1.49

but pion/transport v0.14.0 break with pion/turn/[email protected]

# github.com/pion/turn/v2
../../../../pkg/mod/github.com/pion/turn/[email protected]/client.go:85:16: assignment mismatch: 1 variable but vnet.NewNet returns 2 values
../../../../pkg/mod/github.com/pion/turn/[email protected]/client.go:86:23: config.Net.IsVirtual undefined (type *vnet.Net has no field or method IsVirtual)
../../../../pkg/mod/github.com/pion/turn/[email protected]/relay_address_generator_none.go:21:11: assignment mismatch: 1 variable but vnet.NewNet returns 2 values
../../../../pkg/mod/github.com/pion/turn/[email protected]/relay_address_generator_range.go:37:11: assignment mismatch: 1 variable but vnet.NewNet returns 2 values
../../../../pkg/mod/github.com/pion/turn/[email protected]/relay_address_generator_static.go:25:11: assignment mismatch: 1 variable but vnet.NewNet returns 2 values

[Sean-Der]

@stv0g I think we need to revert and tag things appropriately? People are going to be stuck/confused

Happy to help!

[Sean-Der]

sorry about that @suconghou

I reverted the breaking commits and put them on /v2. I retracted the tagged commits with the breaking changes.

[stv0g]

Hi @Sean-Der,

I did not bump the major version of the module because of this comment here by @at-wat:

v0 may have breaking change without bumping major version according to the semantic versioning.
(I don't have strong opinion about this)

#204 (comment)

But since we receive bug reports, I agree that its probably better to move those changes into /v2.
However, does this mean we will effectively skip v1?