Update mzml2isa to new ISA datatype

[pkrog]

See https://github.com/phnmnl/container-mzml2isa

[pkrog]

Hi @djcomlab , @proccaserra ,
Same question as for nmrml2isa. Do you need some help?

[djcomlab]

@pkrog I believe @Tomnl is responsible for the mzml2isa and nmrml2isa tools.

[pcm32]

I think I already added support right before the cerebellin release. Please check the wrapper. Same goes for nmrml2isa.

…

On Mon, 19 Mar 2018, 16:30 David Johnson, ***@***.***> wrote: @pkrog <https://github.com/pkrog> I believe @Tomnl <https://github.com/tomnl> is responsible for the mzml2isa and nmrml2isa tools. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#24 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWfXmos4sNRK1hExO40PmoxnIl9DzCLks5tf906gaJpZM4RdjH-> .

[Tomnl]

Hi all, I think Pablo has updated mzml2isa-galaxy for this. But I don't think nmrml2isa-galaxy has been updated unless I am looking in the wrong location.

Also, I just want to check: I guess we need to update the original repositories (mzml2isa-galaxy, nmrml2isa-galaxy) as well as the phnmnl repos ?

@RJMW

[pcm32]

I didn't update the repos since, AFAIK, the ISA data type hasn't been PRd and merged to the main galaxy project. But I upgraded both ml2isas wrappers in tools/phenomenal/ms in our galaxy container.

[pcm32]

Mmm, looking at the location suggested by @Tomnl I agree that nmrml2isa hasn't been updated, although I really thought I had done so, apologies!!

[pkrog]

Ok, so for the tool repos we should first submit a PR, right.
For nmrml2isa in phenomenal repos, should I take care of it?

[pcm32]

Sure, go ahead @pkrog!

[djcomlab]

Is this already done and available in the Galaxy runtime container?