Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically updating bounds casues performance issues #389

Open
vorg opened this issue Sep 3, 2024 · 2 comments
Open

Automatically updating bounds casues performance issues #389

vorg opened this issue Sep 3, 2024 · 2 comments
Labels
scope/ecs type/feat A new feature type/perf A code change that improves performance
Milestone

Comments

@vorg
Copy link
Member

vorg commented Sep 3, 2024

attributeName === "aPosition" || attributeName === "aOffset";

@dmnsgn dmnsgn added type/feat A new feature type/perf A code change that improves performance scope/ecs labels Sep 3, 2024
@dmnsgn dmnsgn added this to 4.0.0 Sep 3, 2024
@github-project-automation github-project-automation bot moved this to To do in 4.0.0 Sep 3, 2024
@dmnsgn dmnsgn added this to the 4.0.0 milestone Sep 3, 2024
@dmnsgn
Copy link
Member

dmnsgn commented Sep 3, 2024

Leaning toward the freeze naming as Babylon.js uses it, JS Object.freeze and it could be used for material.freeze as well (although for this issues, Babylon.js has mesh.doNotSyncBoundingInfo = true; but no thank you). But not sure if it is freeze flag list or freeze object or freeze bool:

geometry.freeze = true;

geometry.freeze = new Set(['bounds', 'attributes']);

geometry.freeze = {
  bounds: true,
  attributes: ['aPosition']
}

@vorg
Copy link
Member Author

vorg commented Sep 3, 2024

Well freeze sounds like readOnlyDoNotTouch while i need doNotUpdateIllDoItMyself. Bit different.

My use case allows for updating bounds when e.g. landscape changes but now while it animates. Freeze sounds like object from gltf that has it precomputed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/ecs type/feat A new feature type/perf A code change that improves performance
Projects
Status: To do
Development

No branches or pull requests

2 participants