New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WOPI Proof support #157

Open

nbelyh opened this issue Sep 11, 2023 · 1 comment

Labels

nbelyh commented Sep 11, 2023 •

edited

Loading

Motivation
This a basic WOPI security feature, ensures that request is actually coming from a WOPI server

Here is the documentation:
https://learn.microsoft.com/en-us/microsoft-365/cloud-storage-partner-program/online/scenarios/proofkeys

Describe the solution you'd like
There should be an option to turn on validation on incoming wopi requests.

Here is a sample implementation:
https://github.com/OfficeDev/PnP-WOPI/blob/f8303fe0f218697b0cbaac98736fc9d9ce23e1c9/com.microsoft.dx.officewopi/Utils/WopiUtil.cs#L142C7-L142C7

Describe alternatives you've considered
Not sure.

Am I missing something?

nbelyh added the enhancement label

Owner

petrsvihlik commented Oct 21, 2023

Good idea! Any chance for a PR from your side? :)

petrsvihlik changed the title ~~WOPI Proof support?~~ WOPI Proof support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment