From 3f1e34fd1d8de2e6caade5214a5138797dcff29b Mon Sep 17 00:00:00 2001
From: perryrh0dan <thomaspoehlmann96@googlemail.com>
Date: Sat, 12 Sep 2020 20:42:34 +0200
Subject: [PATCH 1/2] fix(repository): super_templates are working again

---
 .vscode/launch.json        |  2 +-
 src/action/default/init.rs | 10 +++++++-
 src/template/mod.rs        | 47 ++++++++++++++++++++++++++++----------
 src/update/mod.rs          | 18 +++++++++------
 4 files changed, 56 insertions(+), 21 deletions(-)

diff --git a/.vscode/launch.json b/.vscode/launch.json
index 94876d3..608886c 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -18,7 +18,7 @@
             // "args": ["update"],
             // "args": ["init", "-r", "https://github.com/perryrh0dan/templates", "-t", "typescript"],
             // "args": ["repository", "add"],
-            "args": ["init", "ttttt", "-r", "test"],
+            "args": ["init", "-r", "default", "-t", "golang"],
             "cwd": "${workspaceRoot}",
         }
     ]
diff --git a/src/action/default/init.rs b/src/action/default/init.rs
index 176f356..47d920d 100644
--- a/src/action/default/init.rs
+++ b/src/action/default/init.rs
@@ -171,7 +171,15 @@ pub fn init(config: &Config, args: &ArgMatches) {
 
   // Get template specific values
   let mut values = HashMap::new();
-  let keys = template.get_custom_values(&repository);
+  let keys = match template.get_custom_values(&repository) {
+    Ok(keys) => keys,
+    Err(error) => {
+      log::error!("{}", error);
+      println!("{}", error);
+      exit(1);
+    }
+  };
+
   for key in keys {
     let value = match input::text(&format!("Please enter {}", &key), true) {
       Ok(value) => value,
diff --git a/src/template/mod.rs b/src/template/mod.rs
index 38c1467..02b3ba1 100644
--- a/src/template/mod.rs
+++ b/src/template/mod.rs
@@ -22,7 +22,7 @@ pub struct Info {
   version: Option<String>
 }
 
-#[derive(Debug)]
+#[derive(Debug, Clone)]
 pub struct Template {
   pub name: String,
   pub path: PathBuf,
@@ -67,7 +67,10 @@ impl Template {
 
   pub fn copy(&self, repository: &Repository, target: &Path, opts: &context::Context) -> Result<(), RunError> {
     // Get list of all super templates
-    let super_templates = self.get_super_templates(repository);
+    let super_templates = match self.get_super_templates(repository) {
+      Ok(templates) => templates,
+      Err(error) => return Err(error),
+    };
 
     for template in super_templates {
       template.copy(repository, target, opts)?;
@@ -176,18 +179,25 @@ impl Template {
     Ok(())
   }
 
-  pub fn get_custom_values(&self, repository: &Repository) -> Vec<String> {
+  pub fn get_custom_values(&self, repository: &Repository) -> Result<Vec<String>, RunError> {
     // Get list of all super templates
-    let super_templates = self.get_super_templates(repository);
+    let super_templates = match self.get_super_templates(repository) {
+      Ok(templates) => templates,
+      Err(error) => return Err(error),
+    };
 
-    let mut values = vec!{};
+    let mut values: Vec<String>  = vec!{};
     for template in super_templates {
-      values.extend(template.get_custom_values(repository));
+      let v = match template.get_custom_values(repository) {
+        Ok(values) => values,
+        Err(error) => return Err(error),
+      };
+      values.extend(v);
     }
 
     let renderer = match self.meta.renderer.to_owned() {
       Some(data) => data,
-      None => return values,
+      None => return Ok(values),
     };
 
     match renderer.values {
@@ -195,11 +205,11 @@ impl Template {
       None => (),
     };
 
-    values
+    Ok(values)
   }
 
   /// Get list of all super templates
-  fn get_super_templates(&self, repository: &Repository) -> Vec<Template> {
+  fn get_super_templates(&self, repository: &Repository) -> Result<Vec<Template>, RunError> {
     // get list of all super templates
     let super_templates = match &self.meta.extend {
       None => Vec::new(),
@@ -208,11 +218,24 @@ impl Template {
 
     let mut templates = vec!{};
     for name in super_templates {
-      let template = repository.get_template_by_name(&name).unwrap();
-      templates.extend(template.get_super_templates(repository));
+      let template = match repository.get_template_by_name(&name) {
+        Ok(template) =>  template,
+        Err(error) => {
+          log::error!("{}", error);
+          return Err(RunError::Template(String::from("Not found")));
+        },
+      };
+
+      let t = match template.get_super_templates(repository) {
+        Ok(templates) => templates,
+        Err(error) => return Err(error),
+      };
+
+      templates.extend(t);
+      templates.push(template.to_owned());
     }
 
-    templates
+    Ok(templates)
   }
 
   fn is_excluded_renderer(&self, name: &str) -> bool {
diff --git a/src/update/mod.rs b/src/update/mod.rs
index 68f3d3b..c8e616b 100644
--- a/src/update/mod.rs
+++ b/src/update/mod.rs
@@ -18,15 +18,21 @@ const BIN_NAME: &str = "tmpo";
 
 pub fn check_version(verbose: bool) -> Option<self_update::update::ReleaseAsset> {
   log::info!("Fetch release list");
-  let releases = self_update::backends::github::ReleaseList::configure()
+  let releases = match self_update::backends::github::ReleaseList::configure()
     .repo_owner("perryrh0dan")
     .repo_name("tmpo")
     .build()
     .unwrap()
     .fetch()
-    .unwrap();
+  {
+    Ok(releases) => releases,
+    Err(error) => {
+      log::error!("{}", error);
+      return None
+    },
+  };
 
-  // check version
+  // Check version
   let version = crate_version!();
   if releases[0].version == version {
     return None;
@@ -34,7 +40,7 @@ pub fn check_version(verbose: bool) -> Option<self_update::update::ReleaseAsset>
 
   let mut target = self_update::get_target();
 
-  // needs to be investigated
+  // Needs to be investigated
   if target == "x86_64-pc-windows-msvc" {
     target = "x86_64-pc-windows-gnu";
   }
@@ -125,9 +131,7 @@ pub fn update(asset: self_update::update::ReleaseAsset) -> Result<(), RunError>
         self_update::errors::Error::Io { .. } => {
           Err(RunError::Update(String::from("No permission")))
         }
-        _ => {
-          Err(RunError::Update(String::from("Unknown")))
-        }
+        _ => Err(RunError::Update(String::from("Unknown"))),
       }
     }
   };

From b94eed8d8cf74b8a1c5b0d29a081aa125c21e730 Mon Sep 17 00:00:00 2001
From: perryrh0dan <thomaspoehlmann96@googlemail.com>
Date: Sat, 12 Sep 2020 20:46:00 +0200
Subject: [PATCH 2/2] fix(cargo.toml): increment version

---
 Cargo.lock | 2 +-
 Cargo.toml | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Cargo.lock b/Cargo.lock
index 015a9d4..1fe6658 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1575,7 +1575,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
 
 [[package]]
 name = "tmpo"
-version = "1.5.0"
+version = "1.5.1"
 dependencies = [
  "assert_cmd 1.0.1 (registry+https://github.com/rust-lang/crates.io-index)",
  "clap 3.0.0-beta.1 (git+https://github.com/clap-rs/clap/)",
diff --git a/Cargo.toml b/Cargo.toml
index 75ed632..61f1e55 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "tmpo"
-version = "1.5.0"
+version = "1.5.1"
 authors = ["Thomas Pöhlmann <thomaspoehlmann96@googlemail.com>"]
 edition = "2018"