Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libvirt PMDA is missing from centos7 release #1842

Closed
Tualua opened this issue Nov 9, 2023 · 6 comments
Closed

libvirt PMDA is missing from centos7 release #1842

Tualua opened this issue Nov 9, 2023 · 6 comments

Comments

@Tualua
Copy link

Tualua commented Nov 9, 2023

Hello!

libvirt PMDA is available only for centos8 and newer. Is there a reason for it?

@kmcdonell
Copy link
Member

This PMDA needs the Python (version 3.6.8 in this case) module for libvirt. As far as we can tell, this module is not available for CentOS 7, so the PCP packages do not include the libvirt PMDA.

@Tualua
Copy link
Author

Tualua commented Nov 9, 2023

There is python36-libvirt package in EPEL which works. Tested on Oracle Llinux 7.9 with UEK6

diff --git a/build/rpm/pcp.spec.in b/build/rpm/pcp.spec.in
index 80280c2..a5161f8 100755
--- a/build/rpm/pcp.spec.in
+++ b/build/rpm/pcp.spec.in
@@ -1771,8 +1771,12 @@ Requires: python3-pcp python3-lxml
 %if "%{_vendor}" == "suse"
 Requires: python3-libvirt-python
 %else
+%if "%{rhel}" == "7"
+Requires: python36-libvirt
+%else
 Requires: libvirt-python3
 %endif
+%endif
 %else
 Requires: %{__python2}-pcp
 Requires: %{__python2}-lxml

I worked out a patch and built pcp from source. It works.

image

@kmcdonell
Copy link
Member

Thanks for this @Tualua.
I've reworked your patch slightly and added the necessary pcp package list changes ... this is all in commit 68edd7c.
I'll close the issue, please re-open if this does not OK to you.

@Tualua
Copy link
Author

Tualua commented Apr 19, 2024

Hello! As I understand, this commit is included in 6.2.1, I just built RPMs from 6.2.1 source and still got the same error

Error: Package: pcp-pmda-libvirt-6.2.1-1.x86_64 (pcp)
           Requires: libvirt-python3
 You could try using --skip-broken to work around the problem
 You could try running: rpm -Va --nofiles --nodigest```

I looked through your patch and found that you're checking centos version only. You need to check also for rhel, like in my patch to cover Oracle Linux 7

@Tualua
Copy link
Author

Tualua commented Apr 19, 2024

Please open this issue as it is not completed and doesn't solve the original problem

@Tualua
Copy link
Author

Tualua commented Apr 20, 2024

#1962

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants