Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate display size on init #9

Open
nyaray opened this issue Jun 4, 2019 · 1 comment
Open

Validate display size on init #9

nyaray opened this issue Jun 4, 2019 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers paused On hold

Comments

@nyaray
Copy link
Collaborator

nyaray commented Jun 4, 2019 •
edited
Loading

At some point, we should port the screen size checking from the python inky library so that we can fail fast if we detect that the wrong device has been specified in our init opts.
@nyaray nyaray added enhancement New feature or request good first issue Good for newcomers paused On hold labels Jun 4, 2019
@nyaray
Copy link
Collaborator Author

nyaray commented Jun 8, 2019

Since LUTs are about voltage control we should probably implement the eeprom-based display-size validation as there might otherwise be a risk that we basically allow users to tell the screen to fry itself internally... in the worst case.

@nyaray nyaray mentioned this issue Jul 26, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers paused On hold
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nyaray