Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a convenient way to get display info by type #22

Open
lawik opened this issue Jun 24, 2019 · 2 comments
Open

Add a convenient way to get display info by type #22

lawik opened this issue Jun 24, 2019 · 2 comments

Comments

@lawik
Copy link
Collaborator

lawik commented Jun 24, 2019

On the calling side it is usually useful to have access to whatever size the display is. In the Scenic driver I'm already expected to provide that information so it ends up a bit redundant. But it seems like if you pass :phat to the start_link if you could get {:ok, pid, display} it would help.

What do you think?

@lawik
Copy link
Collaborator Author

lawik commented Jun 24, 2019

Add Inky.Display.get_size(type) as the public API to get display info.

@lawik lawik changed the title On starting the genserver, it should provide some display data Add a convenient way to get display info by type Jun 24, 2019
@nyaray
Copy link
Collaborator

nyaray commented Nov 1, 2019

Changing start_link this way would make it behave in a non-standard way, which could lead to confusion. I can see the value of being able to query an Inky process to see what type of display it's been set to run for, though, and having Inky.Display expose functionality to inspect the type once it's up and running... So I guess I'm just ➕ your comment, hehe :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants