Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type ignore #450

Open
5 tasks done
JP-Ellis opened this issue Nov 3, 2023 · 2 comments
Open
5 tasks done

Remove type ignore #450

JP-Ellis opened this issue Nov 3, 2023 · 2 comments
Labels
area:tests Relating to the testing area:upstream Relating to an upstream component difficulty:easy A simple task appropriate for newcomers to the codebase type:chore Part of regular code upkeep

Comments

@JP-Ellis
Copy link
Contributor

JP-Ellis commented Nov 3, 2023

Have you read the Contributing Guidelines on issues?

Prerequisites

  • I'm using the latest version of pact-python.
  • I have read the console error message carefully (if applicable).

Description

There's a couple of places which manually add a # type: ignore[arg-type] due to the upstream issue described in:

Once the upstream issue is resolved, the # type: ignore[arg-type] markers need to be removed.

Reproducible demo

No response

Steps to reproduce

N/A

Expected behavior

N/A

Actual behavior

N/A

Your environment

No response

Self-service

  • I'd be willing to fix this bug myself.
@JP-Ellis JP-Ellis added area:upstream Relating to an upstream component difficulty:easy A simple task appropriate for newcomers to the codebase area:tests Relating to the testing type:chore Part of regular code upkeep labels Nov 3, 2023
@JP-Ellis JP-Ellis moved this to 🚫 Blocked in Pact Python Nov 3, 2023
@cakemanny
Copy link

Upstream issue is fixed in https://github.com/aio-libs/aiohttp/releases/tag/v3.9.4

@JP-Ellis
Copy link
Contributor Author

Thanks for checking up on this! I'm currently on vacation, so I'll get that changed in a couple of weeks.

@JP-Ellis JP-Ellis moved this from 🚫 Blocked to 🚀 To-Do in Pact Python May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:tests Relating to the testing area:upstream Relating to an upstream component difficulty:easy A simple task appropriate for newcomers to the codebase type:chore Part of regular code upkeep
Projects
Pact Python
Status: 🚀 To-Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JP-Ellis @cakemanny