Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building in exercise 14 was renamed, answer code should be changed #28

Open
irnc opened this issue Sep 24, 2019 · 0 comments
Open

Building in exercise 14 was renamed, answer code should be changed #28

irnc opened this issue Sep 24, 2019 · 0 comments
Labels
exercise Issues related to exercise content good first issue

Comments

@irnc
Copy link
Contributor

irnc commented Sep 24, 2019 •
edited
Loading

Building from exercise 14 was renamed from Wirtschaftswissenschaften to Wirtschaftswissenschaften (WIWI). Because name is coded in the answer, it makes exercise invalid. This issue also affects exercise 15 for the same reason.

learnoverpass/content/en/exercises/intro/14.md

Line 24 in eafff0c

way["addr:city"=Passau][name="Wirtschaftswissenschaften"];

Answer should be changed to account for a name change, also exercise content should prepare learner that map is a dynamic object.

NB typing Wirtschaftswissenschaften (WIWI) is not an easy task for non-German speakers, maybe we should allow copy-paste from exercise content?
@irnc irnc added exercise Issues related to exercise content good first issue labels Sep 24, 2019
irnc pushed a commit that referenced this issue Jan 10, 2020
@KristjanESPERANTO @irnc
Add missing ; and use new name for WIWI building (#35)
b0680a3 
* Add missing ;

Without that, the query does not work.

* Use new name for WIWI building in exercises 14 and 15

Solves #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
exercise Issues related to exercise content good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@irnc