Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Rust supportMiddleware: true #312

Open
3 of 5 tasks
beanow-at-crabnebula opened this issue Dec 19, 2023 · 1 comment
Open
3 of 5 tasks

Set Rust supportMiddleware: true #312

beanow-at-crabnebula opened this issue Dec 19, 2023 · 1 comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.

Comments

@beanow-at-crabnebula
Copy link

beanow-at-crabnebula commented Dec 19, 2023

Preflight checklist

Ory Network Project

No response

Describe your problem

I'm looking to add trace instrumentation to the Rust Ory client.
Currently this isn't possible as we're missing middleware support.

Describe your ideal solution

Middleware support is available since:
OpenAPITools/openapi-generator#13946

By generating with this option.
https://github.com/openapitools/openapi-generator/blob/master/docs/generators/rust.md#config-options
supportMiddleware: true

Workarounds or alternatives

Clone the SDK and generate with modified config yourself.

Version

master

Additional Context

NOTE: I think this would be a breaking change for the crate. Since the type of the client would change, anyone setting a client instead of the default would have a type issue and need to wrap it.

Along the lines of this, for a client without middleware added.

- client: my_client
+ client: reqwest_middleware::ClientBuilder(my_client).build()
@beanow-at-crabnebula beanow-at-crabnebula added the feat New feature or request. label Dec 19, 2023
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

1 participant