Allow newlines in description/Add hook points to Data importer process

[Sobuno]

I looked at the logs of the Data Importer cronjob I have running (using Nordigen/GoCardless) and see that the descriptions look a lot nicer before entering Firefly III:

Transfer of salary
We have received the following payment from:
<REDACTED COMPANY NAME>
<REDACTED CITY>
EndToEndID: NOTPROVIDED

In Firefly III, it looks like this:

Transfer of salaryWe have received the following payment from:<REDACTED COMPANY NAME><REDACTED CITY>EndToEndID: NOTPROVIDED

I would move everything except "Transfer of salary" to the Notes field myself with a webhook, but since the newlines are already gone, it's not really possible to restore it correctly.

Looking at the code, I see that Firefly III is intentionally removing newlines from the description (while retaining it for notes). Is it possible to allow newlines in the description or provide some way to interject into the import process in the Data Importer before it is sent to Firefly III?

A third option would of course to have the Data Importer itself recognize that newlines in the description is a no-go and transfer it automatically to Notes or similar.

[JC5]

Mmmm, I'll have to think about this one. Newlines in the descriptions will not be happening, but I can see how this is annoying. But these multi-line descriptions are also terrible.

[floriskruisselbrink]

The main issue here is the stuff GoCardless puts in the field Firefly reads as 'description'.
For some banks this is a very large, seemingly unstructured text with all kinds of information in it, and it definitely isn't very readable if squished together on one line.

For me, it would be a much better solution if there was a possibility for the firefly data-importer to write these 'long descriptions' into the notes field and not in the description field. I don't know if that could be an easy fix?

[JC5]

It would be, although this will mean (potentially) changed transactions for everybody. I've pushed something to the develop branch:

1. Newlines are replaced with spaces in the description, for a cleaner description.
2. If the description contains newlines, it is also added to the notes.

The latest develop image contains the changes.

[JC5]

Note that if you run this, you may see (a lot) of duplicate transactions, depending on your bank.