Destination account does not autocomplete or show required accounts in drop-down

[prostasia]

Support guidelines

• I've read the support guidelines

I've found a bug and checked that ...

• ... the documentation does not mention anything about my problem
• ... there are no open or closed issues that are related to my problem
• ... it's definitely me, not you

Description

I am running Firefly III v5.7.10 on Docker. Most often when I try to add an expense transaction, Firefly III won't accept the Destination (expense) account. It doesn't autocomplete its name, it doesn't show it in the drop-down list, and if I type it in manually, submitting gives this error:

[2023-03-03 23:03:19] local.ERROR: AccountValidator::validateSource cannot handle "Invalid", so it will do a generic check.
[2023-03-03 23:03:19] local.ERROR: AccountValidator::validateDestination cannot handle "Invalid", so it will always return false.

My workaround is to find an old transaction that is similar, clone it, and edit it... that works fine!

Expected behaviour

I would expect it to accept the name of the expense account, and to autocomplete it and/or show it in the drop-down list of accounts.

Debug information

Debug information generated at 2023-03-03 23:38:14 UTC for Firefly III version 5.7.10.

Scope	Version
Firefly III	5.7.10
Firefly III API	1.5.6
Build	242, 14-08-2022 06:31:47 CEST
DB version	18 (exp. 18)
PHP	8.1.9
Host	Linux

System info	Value
System TZ
Browser TZ	America/Los_Angeles
App environment	local
App debug mode	false
App cache driver	file
App logging	info, stack
Display errors	Off
Error reporting	ALL errors
Interface	apache2handler
Default language	en_US
Default locale	equal
BCscale	24
DB drivers	mysql, pgsql, sqlite
Current driver	mysql
Trusted proxies (.env)	**

User info	Value
Login provider	eloquent
User guard	web
Headers	N/A, N/A
Stateful domains
Session start	2023-03-01 00:00:00
Session end	2023-03-31 23:59:59
Session first	2018-02-07 00:00:00
User ID	1
User language	en_US
User locale	en_US
Attempt at "en_US.utf8"	'en_US.utf8'
Attempt at "en_US.UTF-8"	'en_US.UTF-8'
User agent	Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36

Steps to reproduce

1. Enter an expense transaction.
2. Include a valid expense account as the Destination.
3. Submit.

Additional info

In case it makes a difference, I had set up this Firefly instance using the importer, from a much older version. But it has been working mostly fine, except for this.

[JC5]

I suggest you upgrade to the latest version first, then we can look into the issue.

[prostasia]

Sorry for the delay. I just upgraded and am still seeing the same problem.

[JC5]

Alright, let's start with debug mode to see what's being submitted when you press Submit. Could you try again and see what the logs report?

[prostasia]

Does this have what you need?

[2023-05-03 16:34:22] local.DEBUG: Guard array is not empty.  
[2023-05-03 16:34:22] local.DEBUG: Now in guard loop, guard is "api"  
[2023-05-03 16:34:22] local.DEBUG: Result is true  
[2023-05-03 16:34:22] local.DEBUG: Guard says user is authenticated.  
[2023-05-03 16:34:22] local.DEBUG: Now in FireflyIII\Http\Middleware\Authenticate::validateBlockedUser  
[2023-05-03 16:34:22] local.DEBUG: Now in FireflyIII\Support\Request\ChecksLogin::authorize  
[2023-05-03 16:34:22] local.DEBUG: Collect rules of TransactionStoreRequest  
[2023-05-03 16:34:22] local.DEBUG: Going to validate source_id  
[2023-05-03 16:34:22] local.DEBUG: Now in validateOneTransaction()  
[2023-05-03 16:34:22] local.DEBUG: Added NO errors.  
[2023-05-03 16:34:22] local.DEBUG: Now in GroupValidation::validateDescriptions()  
[2023-05-03 16:34:22] local.DEBUG: Now in validateTransactionTypes()  
[2023-05-03 16:34:22] local.DEBUG: Now in validateForeignCurrencyInformation()  
[2023-05-03 16:34:22] local.DEBUG: Now in validateAccountInformation (TransactionValidation) ()  
[2023-05-03 16:34:22] local.DEBUG: Going to loop 1 transaction(s)  
[2023-05-03 16:34:22] local.DEBUG: Transaction type for validator is now "Invalid".  
[2023-05-03 16:34:22] local.DEBUG: Now in AccountValidator::validateSource() {"id":64,"name":"Credit card","iban":null,"number":null} 
[2023-05-03 16:34:22] local.ERROR: AccountValidator::validateSource cannot handle "Invalid", so it will do a generic check.  
[2023-05-03 16:34:22] local.DEBUG: Now in validateGenericSource {"id":64,"name":"Credit card","iban":null,"number":null} 
[2023-05-03 16:34:22] local.DEBUG: Now in findExistingAccount {"id":64,"name":"Credit card","iban":null,"number":null} 
[2023-05-03 16:34:22] local.DEBUG: Valid source account!  
[2023-05-03 16:34:22] local.DEBUG: Now in AccountValidator::validateDestination() {"id":0,"name":"Hosting fees","iban":null,"number":null} 
[2023-05-03 16:34:22] local.ERROR: AccountValidator::validateDestination cannot handle "Invalid", so it will always return false.  
[2023-05-03 16:34:22] local.DEBUG: Now in sanityCheckReconciliation  
[2023-05-03 16:34:22] local.DEBUG: Now in validateEqualAccounts()  
[2023-05-03 16:34:22] local.DEBUG: Now in validateGroupDescription()  
[2023-05-03 16:34:22] local.DEBUG: API endpoint, always assume user wants JSON.  
[2023-05-03 16:34:22] local.DEBUG: Now in Handler::render()  
[2023-05-03 16:34:22] local.DEBUG: Return to parent to handle LaravelValidationException(422)  
172.17.0.1 - - [03/May/2023:16:34:22 +0000] "POST /api/v1/transactions?_token=EVERDslmQp2gGxZoVBfBf7V2QTTbnjhV9kUJVel6 HTTP/1.1" 422 1374 "-" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/107.0.0.0 Safari/537.36"

[JC5]

What's the account type of the "Credit card" account?

[prostasia]

Asset.

[prostasia]

Ah, I just changed it to "Credit card" and that seems to have resolved the problem!

[JC5]

Glad to hear it!