Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One micronaut-test integration test is running with a PURL, but we check for dependency report files. #577

Closed
tromai opened this issue Dec 21, 2023 · 4 comments
Labels
tests Enhancement of tests

Comments

@tromai
Copy link
Member

tromai commented Dec 21, 2023

In this integration test case here, we are running the analysis on a PURL without dependency resolving -purl pkg:maven/io.micronaut/[email protected] --skip-deps. However, we check for two dependencies report files caffeine.json and slf4j.json.
The reason this test case is still passing is because it's reusing caffeine.json and slf4j.json from test cases that run before it.

@tromai tromai added the tests Enhancement of tests label Dec 21, 2023
@behnazh-w
Copy link
Member

behnazh-w commented Dec 21, 2023

That's expected. If dependencies are manually specified in the configuration file, even if the --skip-deps is passed, those dependencies will be analyzed. --skip-deps only skips automatic dependency resolution.

@tromai
Copy link
Member Author

tromai commented Dec 22, 2023

I agree it would be expected if we are analyzing with a yaml config file. However, because we are providing a PURL, --skip-deps here would mean that at most one software component is analyzed. 🤔

@behnazh-w
Copy link
Member

Right, looks like the output comparisons have been mixed up with the test above. I will fix it.

@tromai
Copy link
Member Author

tromai commented Dec 22, 2023

I think this test case used to be a config file test case (which explains the different dependency report files checking). In this PR, it was changed to use a PURL instead (but the comparison for the dependency report files weren't updated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Enhancement of tests
Projects
None yet
Development

No branches or pull requests

2 participants