Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inconsistencies for Location #1

Open
mikebotts opened this issue Oct 17, 2018 · 0 comments
Open

Fix Inconsistencies for Location #1

mikebotts opened this issue Oct 17, 2018 · 0 comments

Comments

@mikebotts
Copy link
Member

The data structure and use of definition attributes are inconsistent for different sensors. In some cases, there is only the sensorLocation observable with no latitude, longitude, or altitude observables, while in other cases, there are 4 observables for location, lat, lon, alt.

The issue seems to stem from a few reasons:
(1) many of the location outputs are the result of using GeoPosHelper in the drivers. The code in GeoPosHelper does not add definition attributes for latitude, longitude, and altitude, thus they get left out of being observables within the Capabilities doc. This may be OK from the standpoint of SOS, but the lack of definitions for Scalars goes against SWE Common Data rules. It also makes it hard to assign, say, altitude to a chart styler without special processing in the data receiver. NOTE: this is also the case for Quaternion vectors, etc. We need discussion on this to determine best approach to control what observables are exposed while complying with the SWE Common Data standard.

(2) The drivers supported through the Android OSH version have a different behavior for location. The later versions (for Android phones, e.g.) tend to include location, longitude, latitude, and altitude, while the newer versions include only location.

@alexrobin alexrobin transferred this issue from opensensorhub/osh-sensors Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant