Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] nodesdn test is flaky #738

Open
dblock opened this issue Dec 16, 2024 · 0 comments
Open

[BUG] nodesdn test is flaky #738

dblock opened this issue Dec 16, 2024 · 0 comments
Labels
bug Something isn't working flaky test help wanted Extra attention is needed

Comments

@dblock
Copy link
Member

dblock commented Dec 16, 2024

What is the bug?

https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12362395741/job/34501630093?pr=737

ERROR   api/nodesdn.yaml (tests/plugins/security/api/nodesdn.yaml)
    ERROR   CHAPTERS
        ERROR   Add distinguished names.
            PASSED  PARAMETERS
                PASSED  cluster_name
            PASSED  REQUEST BODY
            ERROR   RESPONSE STATUS (Expected status 201, but received 500: application/json. Cannot invoke "org.opensearch.security.securityconf.ConfigModel.mapSecurityRoles(org.opensearch.security.user.User, org.opensearch.core.common.transport.TransportAddress)" because "this.configModel" , ...)
            SKIPPED RESPONSE PAYLOAD BODY
            SKIPPED RESPONSE PAYLOAD SCHEMA
            SKIPPED RESPONSE OUTPUT VALUES
        SKIPPED Retrieve distinguished names.
        SKIPPED Update distinguished names.
        SKIPPED Update distinguished names (with cluster name).
        SKIPPED Retrieve distinguished names (with cluster name).
        SKIPPED Delete all distinguished names.
    ERROR   EPILOGUES
        ERROR   DELETE /_plugins/_security/api/nodesdn/opensearch-cluster (Cannot invoke "org.opensearch.security.securityconf.ConfigModel.mapSecurityRoles(org.opensearch.security.user.User, org.opensearch.core.common.transport.TransportAddress)" because "this.configModel" is null)

How can one reproduce the bug?

Intermittent, likely a race condition in OpenSearch security.

What is the expected behavior?

Tests to be reliable.

What is your host/environment?

GHA

Do you have any screenshots?

Screenshot 2024-12-16 at 5 27 25 PM
@dblock dblock added bug Something isn't working untriaged flaky test help wanted Extra attention is needed and removed untriaged labels Dec 16, 2024
@dblock dblock mentioned this issue Dec 17, 2024
Merged
dblock added a commit to dblock/opensearch-api-specification that referenced this issue Dec 17, 2024
@dblock
Added retry for opensearch-project#738.
a53c487 
Signed-off-by: dblock <[email protected]>
Tokesh pushed a commit that referenced this issue Dec 17, 2024
@dblock
Added tests for /_validate/query. (#739)
eb948fb 
* Added tests for /_validate/query.

Signed-off-by: dblock <[email protected]>

* Added retry for #738.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this issue Dec 17, 2024
@dblock @nathaliellenaa
Added tests for /_validate/query. (opensearch-project#739)
5d7569f 
* Added tests for /_validate/query.

Signed-off-by: dblock <[email protected]>

* Added retry for opensearch-project#738.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this issue Dec 18, 2024
@dblock @nathaliellenaa
Added tests for /_validate/query. (opensearch-project#739)
3b07554 
* Added tests for /_validate/query.

Signed-off-by: dblock <[email protected]>

* Added retry for opensearch-project#738.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this issue Jan 7, 2025
@dblock @nathaliellenaa
Added tests for /_validate/query. (opensearch-project#739)
1ac73a1 
* Added tests for /_validate/query.

Signed-off-by: dblock <[email protected]>

* Added retry for opensearch-project#738.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
nathaliellenaa pushed a commit to nathaliellenaa/opensearch-api-specification that referenced this issue Jan 9, 2025
@dblock @nathaliellenaa
Added tests for /_validate/query. (opensearch-project#739)
5fcc105 
* Added tests for /_validate/query.

Signed-off-by: dblock <[email protected]>

* Added retry for opensearch-project#738.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>
dblock added a commit that referenced this issue Jan 9, 2025
@nathaliellenaa @dblock
Added ML Model APIs (#733)
c1651ec 
* Added ML Model APIs (get, search, update model) to the spec along with the tests

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added ML Model APIs (undeploy, unload), moved test for search model to models/search.yaml, resolved conflicts and updated CHANGELOG

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added support for using a certificate and key. (#731)

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>

* Fixed /_search/scroll/{scroll_id}, missing search tests. (#732)

* Fixed /_search/scroll.

Signed-off-by: dblock <[email protected]>

* Added tests for GET and POST /_search.

Signed-off-by: dblock <[email protected]>

* Added a test for GET /_search/pipeline and DELETE /_search/pipeline/{id}.

Signed-off-by: dblock <[email protected]>

* Added missing _search/point_in_time tests.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>

* Added tests for /_validate/query. (#739)

* Added tests for /_validate/query.

Signed-off-by: dblock <[email protected]>

* Added retry for #738.

Signed-off-by: dblock <[email protected]>

---------

Signed-off-by: dblock <[email protected]>
Signed-off-by: Nathalie Jonathan <[email protected]>

* Fixed lint and directory path error.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added ML Model APIs (load, upload, create metadata).

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added ML Model APIs (predict) and updated the test settings for metadata.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Fixed lint errors in predict.yaml, moved setup to prologues and teardown to epilogues in predict.yaml and load.yaml, updated CHANGELOG format, updated API description, 'model_group_id' ID type, 'version' parameter, and made 'model_format' a type of its own in ml.yaml.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added ML Model APIs (chunk, register meta), updated CHANGELOG and test for deprecated model metadata creation API.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Added ML Model APIs (upload chunk), moved test for deprecated chunk upload to create_metadata.yaml, updated CHANGELOG.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Applied suggestions from code review.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Merged main and resolve conflicts.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Moved test models folder to tests/plugins/ml/ml/models, removed duplicate map keys in ml._common.yaml, removed excluded parts and until property in the test files.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Fixed merge conflicts, added support for payload properties into the prologue, attempted to fix errors in predict.yaml.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Rebase with main, fixed test-spec.yml content, added response property in prologues of predict.yaml, undeploy.yaml, unload.yaml, added version for ML Model APIs.

Signed-off-by: Nathalie Jonathan <[email protected]>

* Modified response payload state from RUNNING to COMPLETED.

Signed-off-by: Nathalie Jonathan <[email protected]>

---------

Signed-off-by: Nathalie Jonathan <[email protected]>
Signed-off-by: dblock <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working flaky test help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dblock