Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add WithFieldName implementation to KNNQueryBuilder #2385

Open
dzane17 opened this issue Jan 14, 2025 · 1 comment
Open

[FEATURE] Add WithFieldName implementation to KNNQueryBuilder #2385

dzane17 opened this issue Jan 14, 2025 · 1 comment

Comments

@dzane17
Copy link

dzane17 commented Jan 14, 2025

Is your feature request related to a problem?
We'd like to update relevant query builders with WithFieldName tag so that Query Insights can get field name information when present.

Parent issue: opensearch-project/query-insights#110

What solution would you like?
Add implements WithFieldName here:

public class KNNQueryBuilder extends AbstractQueryBuilder<KNNQueryBuilder> {

Example:
https://github.com/opensearch-project/OpenSearch/blob/a609e634a348b76386fb11936bbe8c4b38ea72d0/server/src/main/java/org/opensearch/index/query/MatchQueryBuilder.java#L59

What alternatives have you considered?
A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?
WithFieldName interface

@jmazanec15
Copy link
Member

jmazanec15 commented Jan 14, 2025

This should be fairly trivial as we already have this information in

.

@vamshin can you assign?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 2.19.0
Development

No branches or pull requests

2 participants