[BUG] Gradle check should be required before merging changes

[peternied]

Describe the bug

Pull requests have been merged without a passing gradle check introducing defects into main. [1] The gradle check is the minimal bar that all changes should pass before they are merged into main to ensure consistent code quality.

• [1] [AUTOCUT] Gradle Check Failure on push to main #12731

Expected behavior

Pull requests should only be allowed to merge without a passing gradle check by the Admin team for the project.

Additional Details

Additional context

• Slack conversation about this issue https://opensearch.slack.com/archives/C05L60S4UBT/p1710783271759989

[peternied]

My thoughts are that I do not think changes should be mergeable unless they pass the gradle check - save a justification that the admin team agrees with and then performs the override.

[andrross]

[Triage - attendees 1 2 3 4 5 6]
@peternied Thanks for filing.

[peternied]

@opensearch-project/admin Could you please update the branch protection rules to require the gradle check in all branches? We have 3 maintainers (myself, @sohami , @reta) approving this issue.

[reta]

@msfroh @dblock FYI :-)

[bbarani]

gradle-check has been added as a mandatory check for all branches.

[reta]

Thanks a lot @bbarani !

[mgodwan]

Pull requests have been merged without a passing gradle check introducing defects into main. [1]

@peternied Please note that the referred PR has not introduced any test defects. The failing tests are due to some other changes which have been fixed by the respective owners