Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align CTA lists without gap on last row on large screens #364

Open
joemull opened this issue Apr 17, 2024 · 0 comments
Open

Align CTA lists without gap on last row on large screens #364

joemull opened this issue Apr 17, 2024 · 0 comments

Comments

@joemull
Copy link
Member

joemull commented Apr 17, 2024

Describe the bug

The CTA list left uses justify-between to control the in-axis spread of flex items, which causes a gap to appear on the last row if there are three items in most rows and two items in the last row.

Example: https://www.openlibhums.org/site/library-governance/

Screenshot from 2024-04-17 13-51-23

Proposed solution

Instead of this, use justify-around, and adjust the gap so that the items do not run too closely together.

Make sure to check a bunch of different uses of this frequently used component, especially as adjusting a gap in a wrapped flex box can cause items to run to the next row when you do not want them to.

Also considered

Use a grid to more closely control the layout of this component on medium and large screens. Check that it still displays properly in all the places it's currently used.

@joemull joemull added the bug Something isn't working label Apr 17, 2024
@joemull joemull added this to the Hourglass bugfixes milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant